improve the update of the source term in the convection diffusion model solver

src/pheromone_dispersion/convection_diffusion_2D.py

@@ -63,9 +63,10 @@ class DiffusionConvectionReaction2DEquation:
     """
 
     # To do:
-    # add exceptions in case
-    # the inv_matrix_implicit_part is not initialized
-    # but should have been
+    # - add exceptions in case
+    #   the inv_matrix_implicit_part is not initialized
+    #   but should have been
+    # - add exceptions to check inputs of __init__
 
     def __init__(self, U, K, coeff_depot, S, msh, time_discretization='semi-implicit', tol_inversion=1e-14):
         r"""
@@ -194,7 +195,7 @@ class DiffusionConvectionReaction2DEquation:
             The associated time array. `None` if the source is stationary.
         """
 
-        setattr(self, 'S', Source(self.msh, value, t=t))
+        self.S = Source(self.msh, value, t=t)
 
     def at_current_time(self, tc):
         r"""
@@ -284,7 +285,7 @@ class DiffusionConvectionReaction2DEquation:
                     self.Id + self.msh.dt * (-self.D + self.R + self.A),
                     c_old + self.msh.dt * self.S.value.ravel(),
                     x0=c_old,
-                    tol=self.tol_inversion,
+                    rtol=self.tol_inversion,
                 )
             # inverse the linear system resulting the implicit time discretization
             # using the pre-computed inverse matrix
@@ -372,7 +373,7 @@ class DiffusionConvectionReaction2DEquation:
                     self.Id + self.msh.dt * (-self.D + self.R + self.A),
                     c_old + self.msh.dt * self.S.value.ravel(),
                     x0=c_old,
-                    tol=self.tol_inversion,
+                    rtol=self.tol_inversion,
                 )
             # inverse the linear system resulting the implicit time discretization
             # using the pre-computed inverse matrix