Skip to content
Snippets Groups Projects
  1. May 28, 2024
  2. May 24, 2024
  3. May 23, 2024
  4. May 16, 2024
  5. May 15, 2024
  6. Apr 25, 2024
  7. Apr 02, 2024
  8. Mar 31, 2024
    • Filippo Rusconi (Uploading Debian Developer)'s avatar
      Introduce provisions to avoid building the new mzMLb feature · f825e3c5
      By using the -DWITHOUT_MZMLB definition, in GNU/Linux and in Windows,
      the library fails to build because #ifndef WITHOUT_MZMLB #endif blocks
      do not succesfully isolate the mzMLb code in pwiz/data/msdata/IO.cpp.
      
      While in GNU/Linux the mzMLb feature can be built fine, in Windows, the
      mzMLb feature cannot be built because the link step fails with numerous
      undefined reference errors, even if the libhdf5_cpp-310.dll library is
      found and the nm / objdump commands show that the purportedly missing
      symbols are indeed exported. The errors all originate from the link of
      the pwiz/data/msdata/mzmlb/Connection_mzMLb.cp file.
      
      So the idea in Windows, is to shunt the mzMLb implementation by:
      
      In CMakeStuff/toolchains/win10-mingw64-toolchain.cmake:
      
        set(hdf5_LIBRARIES "")
        set(hdf5_INCLUDE_DIRS "")
        add_definitions(-DWITHOUT_MZMLB)
      
      Move pwiz/data/msdata/IO-FRusconi-removed-all-mzmlb-related-code.cpp
      to
      pwiz/data/msdata/IO.cpp
      
      In src/CMakeLists.txt:
      
        comment out file
        pwiz/data/msdata/mzmlb/Connection_mzMLb.cpp
        from the list of source files.
      
      With the modifications in place, the library is built on Windows.
      
      When the built library will have been proven to be good at reading
      normal mzML files, we'll change pwiz/data/msdata/IO.cpp by using
      f825e3c5
  9. Mar 30, 2024
Loading