Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G GSAM
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • metexploremetexplore
  • GSAM
  • Merge requests
  • !1

Draft: Time out feature

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Louison Fresnais requested to merge TimeOut_feature into develop Apr 14, 2022
  • Overview 1
  • Commits 6
  • Pipelines 0
  • Changes 1

Problem: GSAM and particularly the code calling RDT remained blocked because of some reactions resulting in several days of computing without any results.

Solution: I modified ComputeGSAM.java to add a timeout.

To do so I created a void called "perform_aam" that performs the atom mapping step. This void is converted to a callable task and called for each entry of rxnSmilesMap. If the executor cannot get the results from the thread before a defined time (default = 6hours) set by the user with the parameter -t, the task is killed and the failed reaction is displayed in the log.

This is a quick and dirty solution. I think the optimal solution would be to define timers directly in RDT and for each algorithm.

Cheers,

Louison

Edited Apr 22, 2022 by Clement Frainay
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: TimeOut_feature