Resolve "Conduites en charge : ajouter loi de Strickler"

Closes #596 (closed)

changed milestone to %Version 4.17.0

added Feature label

assigned to @francois.grand

By Grand Francois on 2023-02-01T15:53:09 (imported from GitLab)

added 17 commits

• b37ef81c - update jalhyd_branch to...
• 2fea08b1 - refactor: modify code to fit encapsulation of properties Nub field
• 0f85a057 - fix(e2e) : Lechapt-Calmon : material change does not modify results
• 85654c12 - test(e2e) : add PressureLoss calculator
• d1cd2406 - chore: update package-lock.json (lodash added to jalhyd)
• cfb78656 - test(e2e): pressure loss: check fields are empty when calculator is created...
• 7c28d21b - refactor : linear head loss coefficient renamed to Klin
• 4b4e8220 - refactor: rename linear head loss to Jlin
• 7eeeeacc - Merge branch 'devel' into...
• 2c7aeb39 - update jalhyd_branch to...
• b0e26ac5 - test(e2e): session reload to check select value: improve report in case of failure
• a7d8b1cf - feat: add Strickler pressure loss law in pressure loss form configuration
• 07a36106 - refactor: FieldSet: remove inSection parameter from setSelectValueFromProperty(), getPropValue()
• d47b59c1 - feat: Stricker calculator: modify form when changing pressure loss law to Strickler
• c2524ad3 - feat: add Strickler locale
• d3fdbdff - refactor: remove PressureLossLaw.calcTypeFromPressureLossLaw
• f59c44e9 - refactor(e2e): disable test on select value after session load

Compare with previous version

By Grand Francois on 2023-02-07T19:12:23 (imported from GitLab)

added 1 commit

• f109a6bb - fix: Lechapt-Calmon: results not reset when changing material select value

Compare with previous version

By Grand Francois on 2023-02-08T08:12:46 (imported from GitLab)

Oups...

By Dorchies David on 2023-02-08T09:10:19 (imported from GitLab)

added 2 commits

• 142576c4 - fix: PressureLossLaw calculator displayed in "other calculation modules"
• 0d576f50 - fix: pressure loss: Strickler coefficient not empty when empty fields flag is true

Compare with previous version

By Grand Francois on 2023-02-08T12:38:46 (imported from GitLab)

marked this merge request as ready

By Grand Francois on 2023-02-08T13:57:43 (imported from GitLab)

Une petite broutille dans la console:

https://hydraulique.g-eau.fr/cassiopee/596-conduites-en-charge-ajouter-loi-de-strickler/app/calculators/pressurelosslaw/fr.json
[HTTP/1.1 404 Not Found 0ms]

Il y a bien un fichier dans src/app/calculators/pressureloss mais pas pressurelosslaw, mais je ne sais pas s'il y a un rapport...

By Dorchies David on 2023-02-08T14:33:08 (imported from GitLab)

Plus gros problème, j'arrive à crasher l'appli si je fais varier un paramètre et que je calcule le Strickler:

Charger la session suivante: session_Crash_Strickler_variable.json

Première chose étrange, le débit apparaît vide à l'écran alors que le fichier json contient bien la variation de débit:

Si on clique sur "Varier", le champ revient à lui.

Si on lance le calcul, celui crashe l'appli:

By Dorchies David on 2023-02-08T14:45:40 (imported from GitLab)

added 11 commits

• 0d576f50...f48601fb - 10 commits from branch devel
• 98b7fd7f - Merge branch 'devel' into 596-conduites-en-charge-ajouter-loi-de-strickler

Compare with previous version

By Grand Francois on 2023-02-09T15:28:09 (imported from GitLab)

added 1 commit

• 8311a05c - fix: error message in browser console about pressure loss law config file

Compare with previous version

By Grand Francois on 2023-02-09T16:30:22 (imported from GitLab)

added 1 commit

• 338f1c6f - fix: add pressure loss calculator documentation

Compare with previous version

By Grand Francois on 2023-02-10T13:40:49 (imported from GitLab)

added 7 commits

• 338f1c6f...2c80448d - 6 commits from branch devel
• 6403762e - Merge branch 'devel' into '596-conduites-en-charge-ajouter-loi-de-strickler'

Compare with previous version

By Dorchies David on 2023-02-13T13:21:49 (imported from GitLab)

enabled an automatic merge when the pipeline for 6403762e succeeds

By Dorchies David on 2023-02-13T13:22:00 (imported from GitLab)

merged

mentioned in commit b141bf1f

By Dorchies David on 2023-02-13T13:45:41 (imported from GitLab)