PréBarrages: Mettre les enfants invalides en rouge dans le schéma

changed milestone to %Version 4.13.1

added To Do enhancement labels

changed milestone to %Version 4.14.0

changed milestone to %Version 4.14.1

changed milestone to %Version 4.14.2

changed milestone to %Version 4.15.0

added Doing label and removed To Do label

assigned to @gargani and unassigned @david.dorchies

By Dorchies David on 2021-12-07T12:18:29 (imported from GitLab)

The Schema is produced from the method PbSchemaComponent.graphDefinition which creates the diagram in the mermaid language.

Mermaid is a javascript library for creating diagrams: https://mermaid-js.github.io/mermaid/#/

A very cool language indead! For example:

flowchart LR
    Start --> Stop

produces:

flowchart LR
    Start --> Stop

And we can also change the color of one box:

flowchart LR
    Start --> Stop
    style Stop fill:#f9f,stroke:#333,stroke-width:4px

flowchart LR
    Start --> Stop
    style Stop fill:#f9f,stroke:#333,stroke-width:4px

In this issue, the task consists in adding one line style for each PbBassin or PbCloison invalid for filling them in red. This can be done when the global style of each basin and cloison is defined:

The big issue is: How can we get the information of the validity of a PbBassin or PbCloison from the class PbSchemaComponent?

By Dorchies David on 2021-12-08T12:35:28 (imported from GitLab)

I tried to find where the validity is available in the code:

Since PbBassin and PbCloison inherit from the class Nub, we can check there validity with the method isComputable.

With these information, it's now really easy to do this task with 4 lines of code

By Dorchies David on 2021-12-14T10:38:49 (imported from GitLab)

The method Nub.isComputable is only checking the range of the parameters. Situation like "the field is empty" or "the field contains something else than numbers" are handled by the UI. So it is not usefull for checking the validity of a child nub of PreBarrage.

By Dorchies David on 2021-12-14T10:38:49 (imported from GitLab)

created merge request !116 (merged) to address this issue

By Dorchies David on 2021-12-13T11:28:28 (imported from GitLab)

mentioned in merge request !116 (merged)

By Dorchies David on 2021-12-13T11:28:29 (imported from GitLab)

mentioned in issue jalhyd#298 (closed)

By Dorchies David on 2021-12-14T15:55:59 (imported from GitLab)

mentioned in commit 17ca971a

By Dorchies David on 2021-12-14T16:16:34 (imported from GitLab)

marked this issue as related to jalhyd#298 (closed)

By Dorchies David on 2021-12-14T16:28:22 (imported from GitLab)

mentioned in commit 17e60053

By Dorchies David on 2021-12-15T17:13:59 (imported from GitLab)

The solution provided in commit 17ca971a is not satisfactory. The compilation failed because this.form.currentNub is casted as Nub and not as a PreBarrage.

Anyway, finally I don't like the idea to put the code checking the parameter in jalhyd since it's only an UI issue. So I prefere to put this code into FormPreBarrage which is both available from CalculatorComponent which updates UI validity and PbSchemaComponent which need draws the scheme with the red nodes in error.

By Dorchies David on 2021-12-15T17:14:54 (imported from GitLab)

mentioned in commit jalhyd@f7d87bf8

By Dorchies David on 2022-02-15T12:20:16 (imported from GitLab)

mentioned in commit 10417819

By Dorchies David on 2022-02-15T15:30:02 (imported from GitLab)

closed

mentioned in commit 61801f84

By Dorchies David on 2022-02-15T15:46:52 (imported from GitLab)

mentioned in issue #544 (closed)

By Dorchies David on 2022-05-17T09:12:20 (imported from GitLab)

PréBarrages: Mettre les enfants invalides en rouge dans le schéma

Designs

Child items ...

Activity