Skip to content
Snippets Groups Projects
Commit c4902c50 authored by mathias.chouet's avatar mathias.chouet
Browse files

Removed TODOs, renamed method

parent 7bdb2744
No related branches found
No related tags found
No related merge requests found
Pipeline #137769 passed
......@@ -46,8 +46,8 @@ export class NgBaseParam extends Observable {
return this._param.checkMax(max);
}
public checkStep(step: number): boolean {
return this._param.checkStep(step);
public checkMinMaxStep(step: number): boolean {
return this._param.checkMinMaxStep(step);
}
public setValue(val: number) {
......
<!-- @TODO copied from var-results.component.html > merge ?-->
<div class="macrorugo-compound-results-table-container" #mrcResultsTable fxLayout="row wrap" fxLayoutAlign="center center">
<div fxFlex="1 1 100%">
<div class="macrorugo-compound-results-table-buttons">
......
<!-- @TODO copied from var-results.component.html > merge ?-->
<div class="pab-results-table-container" #pabResultsTable fxLayout="row wrap" fxLayoutAlign="center center">
<div fxFlex="1 1 100%">
<div class="pab-results-table-buttons">
......
......@@ -365,7 +365,7 @@ export class ResultsChartComponent extends ResultsComponentDirective implements
position: "bottom",
reverse: false
};
// remove tooltips @TODO make them work for multiple series
// remove tooltips
delete this.graph_options.tooltips;
} else {
// enhanced tooltips for single series
......
......@@ -66,7 +66,7 @@ export class JalhydModelValidationMaxDirective implements Validator {
}
/**
* Synchronous validator for Ngparam, relying on JaLHyd ParamDefinition checkStep()
* Synchronous validator for Ngparam, relying on JaLHyd ParamDefinition checkMinMaxStep()
*/
@Directive({
selector: "[appJalhydModelValidationStep]",
......@@ -144,7 +144,7 @@ export function jalhydModelValidatorMax(ngParam: NgParameter): ValidatorFn {
export function jalhydModelValidatorStep(ngParam: NgParameter): ValidatorFn {
return (control: AbstractControl): { [key: string]: any } | null => {
let errorReturn = null; // no error, everything OK
const result = ngParam.checkStep(control.value);
const result = ngParam.checkMinMaxStep(control.value);
if (! result) {
errorReturn = {
"jalhydModelStep": {
......
......@@ -444,8 +444,8 @@ export class NgParameter extends InputField implements Observer {
return this._paramDef.checkMax(max);
}
public checkStep(step: number): boolean {
return this._paramDef.checkStep(step);
public checkMinMaxStep(step: number): boolean {
return this._paramDef.checkMinMaxStep(step);
}
public parseConfig(json: {}) {
......
......@@ -164,7 +164,6 @@ export class I18nService extends Observable implements Observer {
} else {
s = v;
}
// @TODO use sprintf() with named parameters instead ?
m = this.replaceAll(m, "%" + k + "%", s);
}
}
......@@ -174,7 +173,6 @@ export class I18nService extends Observable implements Observer {
/**
* Finds the localized title for a LoiDebit item
* @TODO add StructureType context ? (ex: cem88d / cem88v)
*/
public localizeLoiDebit(l: LoiDebit) {
return this.localizeText("INFO_LOIDEBIT_" + LoiDebit[l]);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment