Skip to content
Snippets Groups Projects
Commit 63b09e91 authored by mathias.chouet's avatar mathias.chouet
Browse files

Fix bug in electron app: semver comparison

parent 5d13cbd9
No related branches found
No related tags found
No related merge requests found
Pipeline #137751 passed
......@@ -50,6 +50,24 @@ function createWindow () {
lookForUpdates();
};
/**
* Compares semver strings
* @see https://github.com/substack/semver-compare
*/
function semverCompare(a, b) {
var pa = a.split('.');
var pb = b.split('.');
for (var i = 0; i < 3; i++) {
var na = Number(pa[i]);
var nb = Number(pb[i]);
if (na > nb) return 1;
if (nb > na) return -1;
if (!isNaN(na) && isNaN(nb)) return 1;
if (isNaN(na) && !isNaN(nb)) return -1;
}
return 0;
}
/**
* Calls the Cassiopee update server to check for available updates;
* if so, displays a desktop notification which, if clicked, will
......@@ -97,7 +115,7 @@ const lookForUpdates = function() {
response.on('data', (chunk) => {
const data = JSON.parse(chunk);
// compare current version to latest version
if (data.latest && data.latest > version) {
if (data.latest && semverCompare(data.latest, version) == 1) {
// get download link for latest version, depending on platform
if (data[data.latest] && data[data.latest][platform]) {
const latestVersionURL = URL + data[data.latest][platform];
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment