FAIDARE issueshttps://forgemia.inra.fr/urgi-is/faidare/-/issues2020-03-25T20:27:07+01:00https://forgemia.inra.fr/urgi-is/faidare/-/issues/19Faidare loader improvment2020-03-25T20:27:07+01:00Jérémy DestinFaidare loader improvment- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/faidare/merge_requests/21#note_10175): (+1 comment)
> TODO
- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/faidare/merge_r...- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/faidare/merge_requests/21#note_10175): (+1 comment)
> TODO
- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/faidare/merge_requests/21#note_10176): (+1 comment)
> TODO
- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/faidare/merge_requests/21#note_10177): (+1 comment)
> TODO
- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/faidare/merge_requests/21#note_10196): (+1 comment)
> Is the data directory ever checked in terms of existence, writability, and so on?
>
> In addition, I think the service should take a File/Path parameter and work with that directly instead of transforming the String into a File. The [`IndexController`](https://forgemia.inra.fr/urgi-is/faidare/merge_requests/21/diffs#1e1beed2dbdad9b33679552ae6b4c40c781ce8b3_0_30) should be used to check the input directory is find, then return a relevant HTTP error without having to enter the Service.https://forgemia.inra.fr/urgi-is/faidare/-/issues/18Add a footer2019-06-06T14:15:02+02:00Célia MichoteyAdd a footerAdd a footer, at leat on GPDS search form/result page with Elixir logo.
Exemple on OLS portal : https://www.ebi.ac.uk/ols/indexAdd a footer, at leat on GPDS search form/result page with Elixir logo.
Exemple on OLS portal : https://www.ebi.ac.uk/ols/indexJérémy DestinJérémy Destinhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/17Add an "About Us" page in GPDS2019-07-08T19:56:04+02:00Célia MichoteyAdd an "About Us" page in GPDSCélia MichoteyCélia Michoteyhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/14Center/Zoom map around the whole group of locations not the first location of...2019-05-06T10:27:48+02:00Guillaume CornutCenter/Zoom map around the whole group of locations not the first location of the groupFor now the map centers and zoom around the first location given in an array.
It would be better to have it centered around the whole group of locations.
Center the bottom marker on the point
view :https://forgemia.inra.fr/urgi-is/gnp...For now the map centers and zoom around the first location given in an array.
It would be better to have it centered around the whole group of locations.
Center the bottom marker on the point
view :https://forgemia.inra.fr/urgi-is/gnpis/blob/develop/www/jsp/common/javaScript/geolocation.jsLaterhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/13Fix bug due to the popover link2019-03-06T15:38:29+01:00Jérémy DestinFix bug due to the popover linkWhen the name where the link is on is to big long there is a display a issue.
Example :
http://localhost:4200/gnpis-core/germplasm?id=aHR0cHM6Ly9kb2kub3JnLzEwLjE1NDU0L0ZaWDhLTw%3D%3D
For the breeding instituteWhen the name where the link is on is to big long there is a display a issue.
Example :
http://localhost:4200/gnpis-core/germplasm?id=aHR0cHM6Ly9kb2kub3JnLzEwLjE1NDU0L0ZaWDhLTw%3D%3D
For the breeding instituteJérémy DestinJérémy Destinhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/12Provide data sources in spring properties rather than backend resources2019-06-20T15:33:49+02:00Guillaume CornutProvide data sources in spring properties rather than backend resourcesRemove the data source metadata in the Java backend resources and move them into spring properties (loaded from spring cloud config or application.yml)
* [ ] Move data sources from `datasources.jsonld` to `application.yaml` (update Data...Remove the data source metadata in the Java backend resources and move them into spring properties (loaded from spring cloud config or application.yml)
* [ ] Move data sources from `datasources.jsonld` to `application.yaml` (update DataSourceRepository)
* [ ] Host logos in `gimli:/webfiles/gpds/logo/` and update URL (check for newer logos, resize to same height)
* [ ] Remove logos from java resources
https://urgi.versailles.inra.fr/jira/browse/GNP-5567LaterGuillaume CornutGuillaume Cornuthttps://forgemia.inra.fr/urgi-is/faidare/-/issues/11Manage fields displayed in germplasm card2019-03-19T10:50:37+01:00Jérémy DestinManage fields displayed in germplasm cardDisplay:
* [x] We should display the BRC logo if this accession is part of a BRC.
* [x] Popover for BRC information ?
* [x] Logo for all institutions.
* [x] Parents name for descendants (add other parent).
* [ ] Factorize popover templat...Display:
* [x] We should display the BRC logo if this accession is part of a BRC.
* [x] Popover for BRC information ?
* [x] Logo for all institutions.
* [x] Parents name for descendants (add other parent).
* [ ] Factorize popover templates for institutes (use parameters ?).
* [x] Order of germplasm card sections (by importance).
* [x] Add donorAccessionNumber to Donation section, in third column (after date and institute) or somewhere else.
* [x] (Minor) Siblings links : remove underline.
* [x] Merge ascendants and -descendants- siblings sections, and rename "accession numbers" to "siblings".
* [x] If the distribution status is "EXTERNAL" and the institute has a web site, we should add the link.
* [x] Add informations on the origin site
* [x] Remove collector.germplasmPUI field ?
* [x] In genealogy part, add parent name for self and unknown parent types, but display nothing for for accession 'unknown'
* [x] In population part, add a link on the population name id it is also an accession18.3Mélanie Buymelanie.buy@inra.frMélanie Buymelanie.buy@inra.frhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/10Add display of missing data and improve visual2019-03-07T10:30:37+01:00Célia MichoteyAdd display of missing data and improve visual- [x] In form, rename "Variable" tab in "Trait"
- [x] In frontend code, replace "gnpis-core/*" by "gnpis/gpds/*" in URL stored in indexes (as indexes for gpds and gnpis-core are the same and we want to stay on gpds and not go to the old ...- [x] In form, rename "Variable" tab in "Trait"
- [x] In frontend code, replace "gnpis-core/*" by "gnpis/gpds/*" in URL stored in indexes (as indexes for gpds and gnpis-core are the same and we want to stay on gpds and not go to the old interface)
- [x] Add missing fields in germplasm card ( [Issue 11](https://forgemia.inra.fr/urgi-is/gpds/issues/11) )
- [x] Manage overflow and underline for links in table. ([Issue 13](https://forgemia.inra.fr/urgi-is/gpds/issues/13) )18.3Jérémy DestinJérémy Destinhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/9Bug: fix result page not updating when going back to it2019-02-22T11:38:26+01:00Guillaume CornutBug: fix result page not updating when going back to itPossible solution: use router.events (filtering NavigationStart && navigation on result page) => exec query param parse to criteria &fetch docsPossible solution: use router.events (filtering NavigationStart && navigation on result page) => exec query param parse to criteria &fetch docs18.3Jérémy DestinJérémy Destinhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/7Handle both card link and documentationURL links (result page and cards)2019-03-07T09:20:48+01:00Guillaume CornutHandle both card link and documentationURL links (result page and cards)19.1Jérémy DestinJérémy Destinhttps://forgemia.inra.fr/urgi-is/faidare/-/issues/4Create spring cloud configuration git2019-02-22T19:13:27+01:00Guillaume CornutCreate spring cloud configuration git@raphael.flores I've added spring cloud configuration to the GPDS backend, we would need to create a configuration server (or re-use the `data-discovery-config` server). What would you recommend?
TODO:
- [x] Configure `.gitlab-ci.yaml` ...@raphael.flores I've added spring cloud configuration to the GPDS backend, we would need to create a configuration server (or re-use the `data-discovery-config` server). What would you recommend?
TODO:
- [x] Configure `.gitlab-ci.yaml` file for deployment
- [x] Create or re-use the `data-discovery-config` server
- [x] YAML configurations for prod (public) + /beta/gnpis/gpds + /staging/gnpis/gpds /int/gnpis/gpds (privé) + /private/gnpis/gpds (privé)
- [x] Update GPDS README.md to document the spring cloud configuration18.3Guillaume CornutGuillaume Cornuthttps://forgemia.inra.fr/urgi-is/faidare/-/issues/3Backend add documentationURL on all BrAPI objects2019-01-25T12:01:41+01:00Jérémy DestinBackend add documentationURL on all BrAPI objectsVariable => `https://urgi.versailles.inra.fr/ontologyportal.do#termIdentifier=${variable.observationVariableDbId}`
@gcornut Ajout dans le Talend variable?
Study => url (dans le l'index ES)
Maybe add programName in /studies/{id} call (i...Variable => `https://urgi.versailles.inra.fr/ontologyportal.do#termIdentifier=${variable.observationVariableDbId}`
@gcornut Ajout dans le Talend variable?
Study => url (dans le l'index ES)
Maybe add programName in /studies/{id} call (if it passes BRAVA)
Germplasm => url (dans le l'index ES)Guillaume CornutGuillaume Cornuthttps://forgemia.inra.fr/urgi-is/faidare/-/issues/2Separate lint from test in gitlab ci pipeline2019-01-25T11:59:16+01:00Guillaume CornutSeparate lint from test in gitlab ci pipelineI would propose to launch the test and lint jobs in parallel in the pipeline
That way, we could more easily see what failed without checking the logs
What do you think @raphael.flores @celia.michotey @jeremy.destin ?I would propose to launch the test and lint jobs in parallel in the pipeline
That way, we could more easily see what failed without checking the logs
What do you think @raphael.flores @celia.michotey @jeremy.destin ?Guillaume CornutGuillaume Cornuthttps://forgemia.inra.fr/urgi-is/faidare/-/issues/1Update Angular to latest version (7.2.0)2019-03-04T16:23:05+01:00Raphaël FloresUpdate Angular to latest version (7.2.0)The following discussion from !2 should be addressed:
- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/gpds/merge_requests/2#note_4221): (+1 comment)
> Not in this branch, but it could be good to bump ...The following discussion from !2 should be addressed:
- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/gpds/merge_requests/2#note_4221): (+1 comment)
> Not in this branch, but it could be good to bump to 7.1.0 which has just been release: https://github.com/angular/angular/tree/7.1.019.1Guillaume CornutGuillaume Cornut