FAIDARE issueshttps://forgemia.inra.fr/urgi-is/faidare/-/issues2019-06-06T14:15:02+02:00https://forgemia.inra.fr/urgi-is/faidare/-/issues/16Responsive: small screen fixes2019-06-06T14:15:02+02:00Guillaume CornutResponsive: small screen fixes- Center accession image horizontally on small screen
=> Add class `justify-content-center` on row https://forgemia.inra.fr/urgi-is/gpds/blob/master/frontend/src/app/germplasm-card/germplasm-card.component.html#L159
- Add non breakable...- Center accession image horizontally on small screen
=> Add class `justify-content-center` on row https://forgemia.inra.fr/urgi-is/gpds/blob/master/frontend/src/app/germplasm-card/germplasm-card.component.html#L159
- Add non breakable space ` ` in result section title (otherwise the`:` wraps to a new line on small screens)
=> `s/Results :/Results :/` https://forgemia.inra.fr/urgi-is/gpds/blob/master/frontend/src/app/result-page/result-page.component.html#L50
- Add space to break text in `Acquisition/Creation date` (otherwise the text overflows in small screens)
=> `s|Acquisition/Creation date|Acquisition / Creation date|` https://forgemia.inra.fr/urgi-is/gpds/blob/master/frontend/src/app/germplasm-card/germplasm-card.component.html#L403
- Fix accession image popover placement on small screen. As-is, it overflows to the right of the screen with no possibility to scroll
- Re-layout the trait widget for small screens (might be difficult!)
Example of accession with an image for the above issues:
http://urgi.versailles.inra.fr/gpds/germplasm?id=ZG9pOjEwLjE1NDU0LzEuNDkyMTc4NTc1ODc5Mzg1M0UxMg%3D%3D
ping @celia.michotey @jeremy.destin @Melanie.Buy @guillaume.cornut https://forgemia.inra.fr/urgi-is/faidare/-/issues/5Uniformize cards (common components, common styles, etc.), after merge correc...2019-04-11T15:08:54+02:00Guillaume CornutUniformize cards (common components, common styles, etc.), after merge correctionsFollow up after the site !6, study !7 and germplasm !4 card are merged all together.
@guillaume.cornut @erik.kimmel @jeremy.destin @Melanie.Buy @raphael.flores @celia.michotey
TODO:
- [x] Refactor map component to work with both site...Follow up after the site !6, study !7 and germplasm !4 card are merged all together.
@guillaume.cornut @erik.kimmel @jeremy.destin @Melanie.Buy @raphael.flores @celia.michotey
TODO:
- [x] Refactor map component to work with both site and study card
- [x] Uniformize card SCSS/HTML
- [x] De-duplicate TypeScript models (for BrAPI objects, site, study, germplasm, etc.)
- [x] Reduce cyclomatic complexity? https://forgemia.inra.fr/urgi-is/gpds/commit/073aece96cd6df60415bcd41be1084794b824dd1#note_5567
- [x] study card
- [x] site card
- [x] germplasm card
- [x] Delete unecessary JS dependencies (is jquery and popper really useful?)
- [x] Re-use the same loading pinner on all cards + result page ([use font awesome spinner](https://fontawesome.com/icons/spinner?style=solid)) https://forgemia.inra.fr/urgi-is/gpds/merge_requests/12/diffs
- [x] Remove error handling in site card in favor of the error interceptor service
- [x] @guillaume.cornut Add tests for form tab switching + test KeyVAlueObject
- [ ] Add documenting tests on all usages of card-row, card-table, card-section
- [x] Resolve warnings on `npm install` https://forgemia.inra.fr/urgi-is/gpds/merge_requests/11/diffs
- [x] Error report with some context (back to last page, hide spinner) https://forgemia.inra.fr/urgi-is/gpds/merge_requests/12/diffs
- [x] @guillaume.cornut Code analysis front/back IntelliJ (fix depreciation warning in tests) https://forgemia.inra.fr/urgi-is/gpds/merge_requests/12/diffs
The following discussion from !6 should be addressed:
- [x] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/gpds/merge_requests/6#note_5427): (+1 comment) => Resolved with addition of card-section/card-row/card-table components
> Don't know the best practice:
> - let the code as is?
> - extract styles in the css file?
>
> Other opinion?
- [x] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/gpds/merge_requests/6#note_5426): (+1 comment)
> Is it a good practice to construct HTML code into an Angular component?
>
> Couldn't we have a dedicated `IconText` component with its own tests and styles in order to avoid such mix?
- [x] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/gpds/merge_requests/6#note_5425): (+3 comments)
> What if the given `sites` array is empty?
The following discussion from !5 should be addressed:
- [ ] @raphael.flores started a [discussion](https://forgemia.inra.fr/urgi-is/gpds/merge_requests/5#note_5862): (+2 comments)
> Another thing, the test here does not check the presence of the two tabs, shouldn't we check that the tabs are loaded correctly with the ontology widget also?18.3Jérémy DestinJérémy Destin