Follow-up from "Improve performances: split queries and aggregations"
The following discussions from !175 should be addressed:
-
@raphael.flores started a discussion: I was not able to find any info on the license of this code section. Did you?
-
@raphael.flores started a discussion: In such case, I'd recommend to remove the deprecated code and its related tests, in order to clean the code base.
-
@raphael.flores started a discussion: I wonder if this section could not be moved in a else part of the
ngIf
so that its does not remain in the DOM when not visible, as shown here: https://www.freakyjolly.com/angular-2-ngif-ngif-else-and-ngif-else-then-tutorial-with-example/ -
@raphael.flores started a discussion: Please, configure your IDE to match format conventions.
Looks that they are not enforced by the versionned Idea stuff...
-
@raphael.flores started a discussion: Some cleaning welcome.
-
@michael.alaux suggested to let the results section visible upon filter application in order to not disturb users in such case. Skeletton should be visible for filters in all cases, and visible for results only when a new query is triggered.