From 884d8d3c9a816f7eadab445c13621ef82053ffc8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Grand?= <francois.grand@inrae.fr>
Date: Tue, 14 Feb 2023 10:11:46 +0100
Subject: [PATCH] refactor: unused code in FormulaireSolveur.update()

refs #601
---
 src/app/formulaire/definition/form-solveur.ts | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/app/formulaire/definition/form-solveur.ts b/src/app/formulaire/definition/form-solveur.ts
index 0a3d446ef..0e3e8db93 100644
--- a/src/app/formulaire/definition/form-solveur.ts
+++ b/src/app/formulaire/definition/form-solveur.ts
@@ -47,11 +47,10 @@ export class FormulaireSolveur extends FormulaireFixedVar {
             }
         }
         // copied from FormFixedVar, to avoid calling super.update()
-        if (data.action === "propertyChange") {
+        else if (data.action === "propertyChange") {
             this.reset();
         }
-
-        if (sender instanceof SelectField) {
+        else if (sender instanceof SelectField) {
             if (sender.id === "select_target_nub" && data.action === "select") {
                 // update Solveur property: Nub to calculate
                 try {
@@ -81,9 +80,7 @@ export class FormulaireSolveur extends FormulaireFixedVar {
                 // reflect changes in GUI
                 const inputXinit = this.getFormulaireNodeById("Xinit") as NgParameter;
                 inputXinit.notifyValueModified(this);
-            }
-        } else if (sender instanceof SelectField) {
-            if (sender.id === this._targettedResultSelectId) {
+            } else if (sender.id === this._targettedResultSelectId) {
                 // refresh parameters selector
                 this.refreshParameterEntries();
             }
-- 
GitLab